Check for sitemaps.log instead of sitemaps directory#11626
Merged
mekarpeles merged 2 commits intomasterfrom Dec 29, 2025
Merged
Check for sitemaps.log instead of sitemaps directory#11626mekarpeles merged 2 commits intomasterfrom
mekarpeles merged 2 commits intomasterfrom
Conversation
mekarpeles
added
the
Priority: 1
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the sitemap generation logic where checking for directory existence was insufficient to determine whether sitemaps needed to be regenerated. The change improves reliability by checking for the actual completion marker (sitemaps.log file) instead of just the directory.
Key Changes:
- Modified the sitemap generation condition to check for
sitemaps.logfile instead of thesitemaps/directory - Aligns with the pattern used elsewhere in the script where file existence (rather than directory existence) indicates completion
- Better handles edge cases where the directory exists but contains no or incomplete sitemap data
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mekarpeles
commented
Dec 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the first part of #7581, correctly implements #11625
Fixes a bug where absence of sitemap directory is preventing sitemaps from being run after
--overwritedeletessitemaps/directory.This pull request makes a small change to the sitemap generation logic in
scripts/oldump.sh. The script now checks for the existence of thesitemaps.logfile instead of thesitemapsdirectory before generating sitemaps.